fix: enable renderFooter for FlatList MessageContainer #914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xcarpentier
approved these changes
Jun 29, 2018
|
@xcarpentier Thanks a lot for the quick review and merge! I really appreciate what you do here as a maintainer, thanks for all your effort! |
chilinh
added a commit
to chilinh/react-native-gifted-chat
that referenced
this pull request
Jul 18, 2018
* r_master: Use IMessage type instead of `any` to define the type of message property (FaridSafi#861) chore(package): update prop-types to version 15.6.2 (FaridSafi#907) fix(package): update uuid to version 3.3.0 (FaridSafi#913) Update InputToolbar.js (FaridSafi#906) Improved typings (FaridSafi#916) fix: enable renderFooter for FlatList MessageContainer (FaridSafi#914) # Conflicts: # index.d.ts
jessestuart
pushed a commit
to jessestuart/react-native-gifted-chat
that referenced
this pull request
Aug 9, 2018
ghost
reviewed
Dec 31, 2018
| renderFooter={this.renderLoadEarlier} | ||
| {...this.props.invertibleScrollViewProps} | ||
| ListFooterComponent={this.renderHeaderWrapper} | ||
| ListHeaderComponent={this.renderFooter} |
There was a problem hiding this comment.
Am i mistaken or are the properties swapped? Shouldn't ListFooterComponent={this.renderFooter}?
There was a problem hiding this comment.
the list is inverted, so header becomes footer and vice versa. So they are swapped on purpose
This was referenced Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes renderFooter gifted chat prop not working with the new Flat List implementation of Message Container (#705 ).
Flat List, compared to List View used before, does not recognise
renderFooterandrenderHeaderprops, so, although they were passed, they were ignored.This PR removes above mentioned props and utilises
ListHeaderComponentprop which is an alternative ofrenderHeaderfor Flat List.