Fix typing.Literal support for Python 3.9
#104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fatal1ty
reviewed
Apr 24, 2023
RA80533
commented
Apr 24, 2023
RA80533
commented
Apr 24, 2023
Fatal1ty
reviewed
Apr 24, 2023
Owner
Fatal1ty
left a comment
Fatal1ty
left a comment
There was a problem hiding this comment.
LGTM. Can you squash and force push all the commits as one to retain you as an author before the merge?
Python 3.9.1 changed the `type()` of `Literal` instances to be `_LiteralGenericAlias` instead of `_GenericAlias`. `is_literal_type()` assumed the change took place in Python 3.9.0 and checked for it accordingly. Because the assumption was incorrect, it failed to detect `Literal` types in Python versions [3.9.0, 3.9.1). This commit changes `is_literal_type()` to check `PY_310_MIN` instead of `PY_39_MIN` to fix the issue.
RA80533
force-pushed
the
fix/literal-support
branch
from
7b45d93 to
aba3857
Compare
Owner
|
Thanks 👍 |
|
@Fatal1ty can we get this fix into a release please? |
Owner
|
@fabiopedrosa Can it wait a bit more? I'm planning to make a release this or next week after finishing the following issues:
Good news is I'm almost done with the first two, just need to update the documentation. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.9.1 changed the
type()ofLiteralinstances to be_LiteralGenericAliasinstead of_GenericAlias.is_literal_type()assumed the change took place in Python 3.9.0 and checked for it accordingly. Because the assumption was incorrect, it failed to detectLiteraltypes in Python versions [3.9.0, 3.9.1).is_literal_type()was changed to checkPY_310_MINinstead ofPY_39_MIN(and check forPY_39separately)test_is_literal_unsupported_python()was updated to mock the updated conditionstest_is_literal_py39()was added to test backwards compatibility for Python versions [3.9.0, 3.9.1)Fixes #103