-
-
Notifications
You must be signed in to change notification settings - Fork 5
Upgrade to @astrojs/starlight 0.32.3 #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Astro.props.id is no longer available and will cause failure
…in site graph plugin
refactor: split up configuration schema file
docs/astro.config.mjs
Outdated
| ], | ||
| components: { | ||
| Head: './src/overrides/Head.astro', | ||
| // Head: './src/overrides/Head.astro', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason for this being commented? On my end (with the PR being locally merged), this works fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me there is error.
There was something wrong with .replace()
If you are sure it works you can modify this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, I did not try building the site, so the opengraph images were never generated. Will fix the issue.
|
Sorry for the delay, thank you very much for the PR! |
|
I didn’t realize so many lines changed in config.ts. |
|
You can checkout this pr and push to it. |
# Conflicts: # packages/starlight-site-graph/config.ts
chore: temporarily disable starlight-theme-obsidian on docs
|
Alright, I also applied the remaining |
The docs depends on https://github.com/Fevol/starlight-theme-obsidian
Here is the other fix Fevol/starlight-theme-obsidian#8