Skip to content

Add hooks to get firestore document data once #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamesdaniels merged 10 commits into from
Feb 12, 2020
Merged

Add hooks to get firestore document data once #211

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
632d876
Add hooks to get firestore document data once
davepwsmith Feb 9, 2020
493beed
Documentation
davepwsmith Feb 9, 2020
d1c3082
Cover using doc with non-existent document
Feb 10, 2020
e213075
Restrict tests to the hooks that they shoud be testing
davepwsmith Feb 11, 2020
244685e
Update observable strings inline with #210
davepwsmith Feb 11, 2020
bcb2e90
Fix test
davepwsmith Feb 11, 2020
51a91e4
Changed the wrong observable reference
davepwsmith Feb 11, 2020
a058cef
use checkStartWithValue for consistency
davepwsmith Feb 11, 2020
4e594af
Observable reference updates wrt #210
davepwsmith Feb 11, 2020
2d0abb8
Merge branch 'master' into master
jamesdaniels Feb 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use checkStartWithValue for consistency
  • Loading branch information
@davepwsmith
davepwsmith committed Feb 11, 2020
commit a058ceff0f6c77a613d95d9742a7521bd9cceb5d
6 changes: 3 additions & 3 deletions reactfire/firestore/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export function useFirestoreDoc<T = unknown>(
return useObservable(
doc(ref),
'firestore doc: ' + ref.path,
options ? options.startWithValue : undefined
checkStartWithValue(options)
);
}

Expand All @@ -63,7 +63,7 @@ export function useFirestoreDocOnce<T = unknown>(
return useObservable(
doc(ref).pipe(first()),
`useFirestoreDocOnce:${ref.path}:${JSON.stringify(options)}`,
options ? options.startWithValue : undefined
checkStartWithValue(options)
);
}

Expand Down Expand Up @@ -116,7 +116,7 @@ export function useFirestoreCollection<T = { [key: string]: unknown }>(
return useObservable(
fromCollectionRef(query, checkIdField(options)),
queryId,
options ? options.startWithValue : undefined
checkStartWithValue(options)
);
}

Expand Down