-
Notifications
You must be signed in to change notification settings - Fork 537
Override VictoryGroup styles with VictoryBoxplot #2824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Override VictoryGroup styles with VictoryBoxplot #2824
Conversation
🦋 Changeset detectedLatest commit: 87cc50f The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@acharyakavita Looks good, can you add this demo to Storybook under |
added story and changeset. |
Description
VictoryGroup was overriding the styles of the child Boxplot with its wrapper styles. To fix this , new role check for `boxplot
is added.
Fixes #1261
Type of Change
How Has This Been Tested?
I tested this against the given code example in the issue and the style is now getting reflected.
Checklist: (Feel free to delete this section upon completion)