cypress5525: Correct a compiler warning #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to be handling an error case incorrectly.
board/hx30/cypress5525.c: In function 'cyp5525_port_int':
board/hx30/cypress5525.c:974:9: error: this 'if' clause does not guard...
[-Werror=misleading-indentation]
974 | if (rv != EC_SUCCESS)
| ^~
board/hx30/cypress5525.c:976:17: note: ...this statement, but the latter
is misleadingly indented as if it were guarded by the 'if'
976 | print_pd_response_code(controller,
| ^~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Simon Glass <[email protected]>
|
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request |
|
This is possibly an incorrect fix. Looking at the same functionality in the hx20 branch, the offending line is just de-indented - EmbeddedController/board/hx20/cypress5525.c Line 973 in 38c1b38 If this is an actual issue, it needs to be resolved in the hx20 board too. |
pantsman0
added a commit
to pantsman0/EmbeddedController
that referenced
this pull request
Apr 7, 2023
Fixes the pd response print in the hx20 board, inline with the approved changes for hx30 at FrameworkComputer#24
Closed
pantsman0
added a commit
to pantsman0/EmbeddedController
that referenced
this pull request
Apr 7, 2023
Applies the Fix from FrameworkComputer#24 into the hx20 board.
kiram9
approved these changes
Apr 26, 2023
Co-authored-by: Daniel Schaefer <[email protected]>
We actually always want to call print_pd_response_code for verbose debugging purposes, so we do not want to wrap this print in the error check
kiram9
approved these changes
May 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be handling an error case incorrectly.
board/hx30/cypress5525.c: In function 'cyp5525_port_int': board/hx30/cypress5525.c:974:9: error: this 'if' clause does not guard...
[-Werror=misleading-indentation]
974 | if (rv != EC_SUCCESS)
| ^~
board/hx30/cypress5525.c:976:17: note: ...this statement, but the latter
is misleadingly indented as if it were guarded by the 'if'
976 | print_pd_response_code(controller,
| ^~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Simon Glass [email protected]