Fixed the missing character in dirname #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Could you please explain what was wrong before and what does this fix? Thanks for your contribution. |
Contributor
Author
Updated in comment. |
prj-
reviewed
Dec 16, 2021
prj-
approved these changes
Dec 17, 2021
pavanakumar
pushed a commit
to pavanakumar/FreeFem-sources
that referenced
this pull request
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The directory name miss a character. For example, using the original shell file, the return value of the
dirnameis/home/zhaog6/teswhen the edp file to edit is in/home/zhaog6/test. The wrong occur on line 219 in shell.cpp.The PR fixs right side of substring of
pathbecausesubstris closed on the left side and open on the right side.