- 
                Notifications
    
You must be signed in to change notification settings  - Fork 145
 
Clarify installation docs #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
          Current coverage is 96.11% (diff: 100%)@@             master       #164   diff @@
==========================================
  Files            12         12          
  Lines           335        335          
  Methods          37         37          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            322        322          
  Misses           13         13          
  Partials          0          0          
  | 
    
        
          
                README.md
              
                Outdated
          
        
      | ## Installing Using [Composer][composer] | ||
| 
               | 
          ||
| Using [Composer][composer]: | ||
| `cd` to your CakePHP directory and run the following command: | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why cakephp dir?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah "your app" or "your project" directory would be more appropriate.
| 
           I am not a too big fan of this, as it should be very clear when working with composer where to be for it to run (where the composer.json file is, so in the app dir). But meh, if it helps some people..  | 
    
          
 My thoughts exactly. There's a chance someone will stop for a second and be uncertain about that. Not everyone has as much experience with composer as you do for instance. I'm unsure what exactly is wrong with saying "your CakePHP directory", but if you feel it's not okay then so be it. Rephrased that portion using what you said, that would make it more helpful.  | 
    
| 
           CakePHP dir = core dir (vendor/cakephp/cakephp) = dangerous tip.  | 
    
          
 I see what you're saying. Sorry about that then.  | 
    
Description
Made it obvious one has to
cdinto their CakePHP directory and run the composer command from it.Summarize
Edited
README.md