This repository was archived by the owner on Feb 16, 2019. It is now read-only.
PSR-4 #127
Closed
PSR-4 #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
fabbot.io doesn't seem to have picked up the pull correctly. :( |
Contributor
Author
|
This needs rebasing, so I'll just resend it. Maybe fabbot.io will pick it up correctly the second time. |
Member
|
I'm against changing the directory structure. The current is simple and straightforward and does not forbid to use PSR-4, right? |
Contributor
Author
|
Hmmm, technically no, but PSR-0 will be deprecated soonish, but I assume support won't be removed from composer because of the wide usage, and indeed because symfony uses it. I'm just suggesting we change it now since it may be a while until we come around to thinking about Sami 4.0. |
Member
|
I'm not against moving to PSR-4 but I don't want to change the directory structure. |
Contributor
Author
|
Oh, ok. Sure. I'll send a pull just to update the composer.json then. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now would be a great time to move over to PSR-4 autoloading.