This repository was archived by the owner on Feb 16, 2019. It is now read-only.
Show sub-namespaces on namespace page #13
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sami/Project.php
Outdated
Member
There was a problem hiding this comment.
{ should be on the previous line.
Contributor
|
+1 |
Contributor
|
Closes #119 |
Contributor
There was a problem hiding this comment.
I guess this was added by mistake.
Contributor
There was a problem hiding this comment.
I found some issues with this PR, so I'm working on an alternative that I'll submit this weekend.
On Aug 23, 2014, at 1:39 AM, Alexander Obuhovich [email protected] wrote:
In Sami/Resources/themes/default/pages/namespace.twig:
@@ -22,7 +35,7 @@
{% endfor %}
{% endif %}
- I guess this was added by mistake.
—
Reply to this email directly or view it on GitHub.
This was referenced Aug 24, 2014
fabpot
added a commit
that referenced
this pull request
Oct 23, 2014
…es (mtdowling) This PR was squashed before being merged into the 2.0-dev branch (closes #124). Discussion ---------- Adding a theme based on twitter bootstrap not using frames This commit adds a bootstrap 3 powered theme to Sami that does not use frames. Closes #119, #122, #47, #13, #123. This pull request adds a new theme that is completely rewritten to be simpler, not use frames, and is now responsive (i.e., looks good on a phone). I've re-implemented the left-navigation using a much simpler approach, created a new search implementation that allows users to hook in custom search result types by extending the theme, and added breadcrumbs. I tried to keep a relatively similar look and feel to the existing Sami theme, but with a bit of twitter bootstrap on top. Because this provides the same features of the default theme and includes additional features, I would recommend making this the default theme and removing the "enhanced" theme. If you'd like me to do this, then let me know and I'll rebase with those changes. Here are some screenshots and descriptions of what they do. Namespaces ---- This is the namespaces page. It just lists each namespace. This is also the homepage if a project has classes.  Here is is at a smaller width:  Note: the button at the top provides a drop down containing the menu. Classes ----- Here is the "classes" page, full-screen.  And again, small screen:  Note: Traits, and interfaces look that same as this page. Index page (doc-index) ----  This looks good on a phone too:  Interface ---- Here's an interface page. Just like with class and namespace pages, the left-nav is scrolled down to show the currently selected node.  Here are the start of the methods:  Namespace page ---- Here's a namespace page. It lists the sub-namespaces, the classes, traits, interfaces, etc.  Search page ----- When you submit a search query, it takes you to this page.  The search looks through the names of each thing in the search index. The search index contains each namespace, class, interface, trait, and methods from each of these. Commits ------- 91a2bf8 Adding a theme based on twitter bootstrap not using frames
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.