Skip to content
This repository was archived by the owner on Feb 16, 2019. It is now read-only.

Conversation

@gquemener
Copy link

I'm not sure this PR should be merged on master.
Don't hesitate to tell me on which one you'd like me to recreate it if it's not the correct one.

@gquemener
Copy link
Author

Something's wrong with the "blackfire" build:

$ if [[ "$BLACKFIRE" = "on" ]]; then
      openssl aes-256-cbc -K $encrypted_16ab3ffdcd52_key -iv $encrypted_16ab3ffdcd52_iv -in .blackfire.travis.ini.enc -out ~/.blackfire.ini -d
      curl -L https://blackfire.io/api/v1/releases/agent/linux/amd64 | tar zxpf -
      chmod 755 agent && ./agent --config=~/.blackfire.ini --socket=unix:///tmp/blackfire.sock &
  fi

iv undefined
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   620    0   620    0     0   1664      0 --:--:-- --:--:-- --:--:--  2190
100 2907k  100 2907k    0     0  1984k      0  0:00:01  0:00:01 --:--:-- 2939k
install
[2015-11-30T23:22:34Z] ERROR: Error while reading configuration file: No [blackfire] section found

@gquemener
Copy link
Author

ping @fabpot

@fabpot
Copy link
Member

fabpot commented Jan 19, 2016

Using Symfony 3 means upgrading to PHP 5.5, not sure it is worth it.

@aik099
Copy link
Contributor

aik099 commented Jan 19, 2016

Maybe we can do combined constraint as in other projects, like ^2.5|^3.0.

@GrahamCampbell
Copy link
Contributor

Maybe we can do combined constraint as in other projects, like ^2.5|^3.0.

Not possible because we ship a lock file.

@aik099
Copy link
Contributor

aik099 commented Jan 19, 2016

For Symfony 3-based projects, where Sami is used as a dependency, not as PHAR that would make life easier.

@GrahamCampbell
Copy link
Contributor

True.

@schnittstabil
Copy link

Is there any progress on this? I'm a bit lost, I want to use sami and symfony/finder ^3.0 as dependencies, but sami depends on symfony/finder ~2.1 😒

@javiereguiluz
Copy link
Contributor

Same error here. I can't upgrade an application to Symfony 3.0 because of the sami dependency.

@gquemener
Copy link
Author

Sorry here, I ain't got no time to rebase nor review this PR. I'm keeping it open for review by an admin.

Feel free to close :)

Cheers!

@mzur
Copy link
Contributor

mzur commented Aug 25, 2016

I support this update since Laravel 5.3 is no longer compatible with Sami. The official Laravel API documentation requires a hack to still use Sami. PHP 5.4 is no longer supported for over a year now so maybe the update can be reconsidered?

@fabpot
Copy link
Member

fabpot commented Sep 10, 2016

Closing in favor of #235

@fabpot fabpot closed this Sep 10, 2016
@fabpot fabpot mentioned this pull request Sep 10, 2016
fabpot added a commit that referenced this pull request Sep 11, 2016
This PR was merged into the 3.3-dev branch.

Discussion
----------

upgraded to Symfony 3.0

Upgrading to Symfony 3.0 means :

* removal of 5.3 and 5.4 support;
* bumping to a new major version.

As we have a new major version, I have also:

* removed support for Twig 1.x;
* upgraded to PHPParser version 3.0.

Fixes #232, #192, #217, #216, and #228

Commits
-------

aba7a3f updated PHP requirement to PHP 5.5
2abd94e bumped PHPParser to 3.0, removed support for Twig 1.x
8c20f4c upgraded to Symfony 3.0
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants