-
Notifications
You must be signed in to change notification settings - Fork 286
Updated to Symfony 3 #192
Updated to Symfony 3 #192
Conversation
|
Something's wrong with the "blackfire" build: $ if [[ "$BLACKFIRE" = "on" ]]; then
openssl aes-256-cbc -K $encrypted_16ab3ffdcd52_key -iv $encrypted_16ab3ffdcd52_iv -in .blackfire.travis.ini.enc -out ~/.blackfire.ini -d
curl -L https://blackfire.io/api/v1/releases/agent/linux/amd64 | tar zxpf -
chmod 755 agent && ./agent --config=~/.blackfire.ini --socket=unix:///tmp/blackfire.sock &
fi
iv undefined
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 620 0 620 0 0 1664 0 --:--:-- --:--:-- --:--:-- 2190
100 2907k 100 2907k 0 0 1984k 0 0:00:01 0:00:01 --:--:-- 2939k
install
[2015-11-30T23:22:34Z] ERROR: Error while reading configuration file: No [blackfire] section found |
|
ping @fabpot |
|
Using Symfony 3 means upgrading to PHP 5.5, not sure it is worth it. |
|
Maybe we can do combined constraint as in other projects, like |
Not possible because we ship a lock file. |
|
For Symfony 3-based projects, where Sami is used as a dependency, not as PHAR that would make life easier. |
|
True. |
|
Is there any progress on this? I'm a bit lost, I want to use |
|
Same error here. I can't upgrade an application to Symfony 3.0 because of the sami dependency. |
|
Sorry here, I ain't got no time to rebase nor review this PR. I'm keeping it open for review by an admin. Feel free to close :) Cheers! |
|
I support this update since Laravel 5.3 is no longer compatible with Sami. The official Laravel API documentation requires a hack to still use Sami. PHP 5.4 is no longer supported for over a year now so maybe the update can be reconsidered? |
|
Closing in favor of #235 |
This PR was merged into the 3.3-dev branch. Discussion ---------- upgraded to Symfony 3.0 Upgrading to Symfony 3.0 means : * removal of 5.3 and 5.4 support; * bumping to a new major version. As we have a new major version, I have also: * removed support for Twig 1.x; * upgraded to PHPParser version 3.0. Fixes #232, #192, #217, #216, and #228 Commits ------- aba7a3f updated PHP requirement to PHP 5.5 2abd94e bumped PHPParser to 3.0, removed support for Twig 1.x 8c20f4c upgraded to Symfony 3.0
I'm not sure this PR should be merged on master.
Don't hesitate to tell me on which one you'd like me to recreate it if it's not the correct one.