Add deleted threads list #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
+1 |
Contributor
Author
|
ping ;) |
Member
There was a problem hiding this comment.
Could you add something here to indicate that the list is displaying deleted threads?
Member
|
Sorry for the delay. If you could address my (minor) suggestion I'm happy to merge this. |
Contributor
Author
|
I just added a comment at the top of the file. Is it ok ? |
Member
|
Sorry, I meant more that the template |
Contributor
Author
|
Sorry ! I just pushed the update, I kept the "short" title style (like for "Sent", etc). Tell me if you prefer a longer title. |
Member
|
Thanks, one more change though (sorry) - better to not include the translation for languages that we're not sure what it'd be. We dont want it to silently fail for those languages. |
Contributor
Author
|
Sure, no pb, done ! |
Member
|
Thanks |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a /deleted route with all user (soft) deleted threads.
I have tested queries in both ORM and ODM, it seems to be ok.