-
Notifications
You must be signed in to change notification settings - Fork 183
Added an optional flashmessage listener #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
9e02547
Added a flashmessage listener
Miliooo f21d3ea
some updates
Miliooo ef1ee68
some refactoring with the key and the config
Miliooo 8e1d37b
refactored to use parameter
Miliooo 31de539
fixed naming of test
Miliooo 97fd7dd
updated config reference
Miliooo fb105f3
added config tests
Miliooo ac283df
test updates
Miliooo f884e39
small updates, just hope this time the travis build passes
Miliooo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
added config tests
- Loading branch information
commit fb105f3a18ee565c71c9f3b97bf91650e333e552
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,141 @@ | ||
| <?php | ||
|
|
||
| namespace FOS\MessageBundle\Tests\DependencyInjection; | ||
|
|
||
| use FOS\MessageBundle\DependencyInjection\FOSMessageExtension; | ||
| use Symfony\Component\DependencyInjection\ContainerBuilder; | ||
| use Symfony\Component\Yaml\Parser; | ||
|
|
||
| class FOSMessageExtensionTest extends \PHPUnit_Framework_TestCase | ||
| { | ||
|
|
||
| /** @var ContainerBuilder */ | ||
| protected $configuration; | ||
|
|
||
| /** | ||
| * @expectedException \Symfony\Component\Config\Definition\Exception\InvalidConfigurationException | ||
| */ | ||
| public function testMessageLoadThrowsExceptionUnlessDbDriverSet() | ||
| { | ||
| $loader = new FOSMessageExtension(); | ||
| $config = $this->getEmptyConfig(); | ||
| unset($config['db_driver']); | ||
| $loader->load(array($config), new ContainerBuilder()); | ||
| } | ||
|
|
||
| /** | ||
| * @expectedException \Symfony\Component\Config\Definition\Exception\InvalidConfigurationException | ||
| */ | ||
| public function testMessageLoadThrowsExceptionUnlessThreadClassSet() | ||
| { | ||
| $loader = new FOSMessageExtension(); | ||
| $config = $this->getEmptyConfig(); | ||
| unset($config['thread_class']); | ||
| $loader->load(array($config), new ContainerBuilder()); | ||
| } | ||
|
|
||
| /** | ||
| * @expectedException \Symfony\Component\Config\Definition\Exception\InvalidConfigurationException | ||
| */ | ||
| public function testMessageLoadThrowsExceptionUnlessMessageClassSet() | ||
| { | ||
| $loader = new FOSMessageExtension(); | ||
| $config = $this->getEmptyConfig(); | ||
| unset($config['message_class']); | ||
| $loader->load(array($config), new ContainerBuilder()); | ||
| } | ||
|
|
||
| /** | ||
| * @expectedException \InvalidArgumentException | ||
| * @expectedExceptionMessage Invalid db driver "foo" | ||
| */ | ||
| public function testUnsupportedDbDriverThrowsException() | ||
| { | ||
| $loader = new FOSMessageExtension(); | ||
| $config = $this->getEmptyConfig(); | ||
| $config['db_driver'] = "foo"; | ||
| $loader->load(array($config), new ContainerBuilder()); | ||
| } | ||
|
|
||
| public function testFlashesAreDisabledByDefault() | ||
| { | ||
| $this->createEmptyConfiguration(); | ||
| $this->assertNotHasDefinition('fos_message.flash_listener'); | ||
| } | ||
|
|
||
| public function testUserEnablesFlashes() | ||
| { | ||
| $this->configuration = new ContainerBuilder(); | ||
| $loader = new FOSMessageExtension(); | ||
| $config = $this->getEmptyConfigWithFlashesEnabled(); | ||
| $loader->load(array($config), $this->configuration); | ||
|
|
||
| $this->assertHasDefinition('fos_message.flash_listener'); | ||
| $this->assertParameter('success', 'fos_message.flash_messages_key'); | ||
| } | ||
|
|
||
| protected function createEmptyConfiguration() | ||
| { | ||
| $this->configuration = new ContainerBuilder(); | ||
| $loader = new FOSMessageExtension(); | ||
| $config = $this->getEmptyConfig(); | ||
| $loader->load(array($config), $this->configuration); | ||
| $this->assertTrue($this->configuration instanceof ContainerBuilder); | ||
| } | ||
|
|
||
| /** | ||
| * getEmptyConfig | ||
| * | ||
| * @return array | ||
| */ | ||
| protected function getEmptyConfig() | ||
| { | ||
| $yaml = <<<EOF | ||
| db_driver: mongodb | ||
| thread_class: Acme\MyBundle\Entity\Thread | ||
| message_class: Acme\MyBundle\Entity\Message | ||
| EOF; | ||
| $parser = new Parser(); | ||
|
|
||
| return $parser->parse($yaml); | ||
| } | ||
|
|
||
| protected function getEmptyConfigWithFlashesEnabled() | ||
| { | ||
| $yaml = <<<EOF | ||
| db_driver: mongodb | ||
| thread_class: Acme\MyBundle\Entity\Thread | ||
| message_class: Acme\MyBundle\Entity\Message | ||
| flash_messages: | ||
| enabled: true | ||
| EOF; | ||
| $parser = new Parser(); | ||
|
|
||
| return $parser->parse($yaml); | ||
| } | ||
|
|
||
| /** | ||
| * @param mixed $value | ||
| * @param string $key | ||
| */ | ||
| private function assertParameter($value, $key) | ||
| { | ||
| $this->assertEquals($value, $this->configuration->getParameter($key), sprintf('%s parameter is correct', $key)); | ||
| } | ||
|
|
||
| /** | ||
| * @param string $id | ||
| */ | ||
| private function assertHasDefinition($id) | ||
| { | ||
| $this->assertTrue(($this->configuration->hasDefinition($id) ? : $this->configuration->hasAlias($id))); | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. please remove the space in the shortcur ternay operator
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. and you should use |
||
| } | ||
|
|
||
| /** | ||
| * @param string $id | ||
| */ | ||
| private function assertNotHasDefinition($id) | ||
| { | ||
| $this->assertFalse(($this->configuration->hasDefinition($id) ? : $this->configuration->hasAlias($id))); | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please rename the property to
containerBuilder. It will be more readable