Conversation
JoshuaBatty
temporarily deployed
to
fuel-sway-bot
GitHub Actions
Inactive
PR SummaryMedium Risk Overview CI and release packaging are updated to stop building/testing/stripping/archiving Written by Cursor Bugbot for commit 21a03de. This will update automatically on new commits. Configure here. |
JoshuaBatty
temporarily deployed
to
fuel-sway-bot
GitHub Actions
Inactive
JoshuaBatty
temporarily deployed
to
fuel-sway-bot
GitHub Actions
Inactive
JoshuaBatty
temporarily deployed
to
fuel-sway-bot
GitHub Actions
Inactive
## Summary - Remove `forc-client` dependency from the test crate and use the `fuels` SDK directly for contract deployment and script execution in the e2e test harness - `deploy_contract()` now uses `forc_pkg` build + `Contract::regular().deploy()` - `runs_on_node()` now uses `forc_pkg` build + `ScriptTransactionBuilder` with proper coin resolution via `adjust_for_fee()` - This eliminates version mismatch issues since `forc_pkg` (always in sync with sway-core) handles compilation while the fuels SDK handles on-chain operations Prerequisite step for #7545 which migrates `forc-client` out of this repo entirely. ## Test plan - [x] All 12 contract deployment e2e tests pass against a local fuel-core node - [x] Verified functional parity with old forc-client approach (same salt, script data, contract inputs/outputs, variable output policy, coin resolution pattern) - [x] CI e2e tests pass --------- Co-authored-by: Igor Rončević <ironcev@hotmail.com>
JoshuaBatty
force-pushed
the
josh/remove_forc_client
branch
from
9b35cc1 to
b56157b
Compare
JoshuaBatty
temporarily deployed
to
fuel-sway-bot
GitHub Actions
Inactive
This PR completes the sway-side of migrating `forc-client` to the forc monorepo, as outlined in RFC #49. The corresponding forc repo PR: FuelLabs/forc#143 `forc-client` has already been released from the forc repo (v0.71.1). ### Changes - Remove `forc-client` crate from workspace - Update CI to no longer build/test/package `forc-client` binaries (forc-deploy, forc-run, forc-submit, forc-call) - Update gh-pages workflow to install `forc-client` from forc repo - Remove unused workspace dependencies (aws-config, aws-sdk-kms, k256) - Update forc-mcp to use forc-client's re-exported Gas type ### Distribution Going forward, `forc-client` will be built and distributed from the forc repo by: - sway-nightly-binaries - fuelup - fuel.nix
JoshuaBatty
force-pushed
the
josh/remove_forc_client
branch
from
b56157b to
9838fb6
Compare
JoshuaBatty
temporarily deployed
to
fuel-sway-bot
GitHub Actions
Inactive
|
👍 |
ironcev
temporarily deployed
to
fuel-sway-bot
GitHub Actions
Inactive
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Remove unused workspace dependencies (`forc-wallet`, `dialoguer`, `rpassword`) as a result of removing `forc-client` in #7545.
4 participants
Summary
This PR completes the sway-side of migrating
forc-clientto the forc monorepo, as outlined in RFC #49.The corresponding forc repo PR: FuelLabs/forc#143
forc-clienthas already been released from the forc repo (v0.71.1).Changes
forc-clientcrate from workspaceforc-clientbinaries (forc-deploy, forc-run, forc-submit, forc-call)forc-clientfrom forc repo for documentation generationaws-config,aws-sdk-kms,k256)Distribution
Going forward,
forc-clientwill be built and distributed from the forc repo by:Documentation
Documentation for all tooling will continue to live in this repo. The
gh-pagesworkflow now pullsforc-clientfrom the forc repo rather than building it locally, so docs generation continues to work as before.