Skip to content

Change traverse default behavior to avoid nx import #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Change traverse default behavior to avoid nx import #327

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ldp/graph/ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ def get_upstream_results(self, op: str | Op) -> Iterator[OpResult]:

def traverse(
self,
topological_order: bool = True,
topological_order: bool = False,
Copy link
Collaborator

@sidnarayanan sidnarayanan Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm cool with changing the default, but can you pass topological_order=True here:

ldp/src/ldp/graph/ops.py

Line 119 in 3d874c5

for node in self.traverse():
? That's the only place we currently require topological sorting.

filter_fn: Callable[[OpResult], bool] = lambda _: True,
) -> Iterator[OpResult]:
"""Traverse the compute graph that led to this OpResult.
Expand All @@ -256,7 +256,7 @@ def traverse(
order. This requires having the whole graph in memory. If False,
traverse the backwards graph in depth-first order. This can be done
lazily and is useful if we are trying to hydrate the graph node-by-node.
Most user-facing cases can leave this as True. Defaults to True.
Probably True is a better default, but to avoid nx import we set to False.
filter_fn: Will only yield nodes that pass this filter function. Note that
nodes that fail will still be traversed.

Expand Down
Loading