Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Renamed query_transformer to query_factory to be direct
  • Loading branch information
jamesbraza committed Aug 7, 2025
commit 4157215839c21ae5201a8dbbe976e2331b1769b6
8 changes: 4 additions & 4 deletions src/paperqa/clients/client_models.py
Original file line number Diff line number Diff line change
Expand Up @@ -94,22 +94,22 @@ class MetadataProvider(ABC, Generic[ClientQueryType]):
"""

async def query(self, query: dict) -> DocDetails | None:
return await self._query(self.query_transformer(query))
return await self._query(self.query_factory(query))

@abstractmethod
async def _query(self, query: ClientQueryType) -> DocDetails | None:
"""Run a query against the provider."""

@abstractmethod
def query_transformer(self, query: dict) -> ClientQueryType:
def query_factory(self, query: dict) -> ClientQueryType:
"""Create a query object from unstructured query data."""


class DOIOrTitleBasedProvider(MetadataProvider[DOIQuery | TitleAuthorQuery]):

async def query(self, query: dict) -> DocDetails | None:
try:
client_query = self.query_transformer(query)
client_query = self.query_factory(query)
return await self._query(client_query)
# We allow graceful failures, i.e. return "None" for both DOI errors and timeout errors
# DOINotFoundError means the paper doesn't exist in the source, the timeout is to prevent
Expand Down Expand Up @@ -153,7 +153,7 @@ async def _query(self, query: DOIQuery | TitleAuthorQuery) -> DocDetails | None:
TimeoutError: When the request takes too long on the client side
"""

def query_transformer(self, query: dict) -> DOIQuery | TitleAuthorQuery:
def query_factory(self, query: dict) -> DOIQuery | TitleAuthorQuery:
try:
if "doi" in query:
return DOIQuery(**query)
Expand Down