Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates HTTP client libraries by replacing aiohttp with httpx throughout the repository to achieve a single, unified HTTP client approach.
- Replace
aiohttp.ClientSessionwithhttpx.AsyncClientacross all test files - Update exception handling from
aiohttp.ClientResponseErrortohttpx.HTTPStatusError - Refresh test cassettes with new HTTP request headers and formatting changes from the httpx client
Reviewed Changes
Copilot reviewed 41 out of 51 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/test_clinical_trials.py | Updates test fixtures and mocks to use httpx instead of aiohttp for clinical trials API testing |
| tests/test_clients.py | Replaces aiohttp.ClientSession with httpx.AsyncClient in metadata client tests and updates citation count test data |
| tests/cassettes/*.yaml | Updates VCR cassettes with new request headers and response formatting from httpx instead of aiohttp |
e04ddb9 to
0d51fd6
Compare
Collaborator
|
Why the rename? Won't that break backwards compatibility? |
Collaborator
Author
You mean rename from
I thought the name change was good because:
|
whitead
reviewed
Aug 16, 2025
0d51fd6 to
324a5a3
Compare
324a5a3 to
008e269
Compare
cbf01a2 to
d383e5a
Compare
mskarlin
approved these changes
Aug 25, 2025
db9614d to
d0ef74f
Compare
d0ef74f to
90162b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
aiohttpandhttpxcoexisted in this repoAfter: we just have
httpx