Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements retry logic for Context creation when LLMs produce malformed JSON, preventing crashes in the gather_evidence function.
- Adds retry mechanism for Context creation with failure details passed to second attempt
- Creates proper error handling that abandons Context creation after two failures with helpful logging
- Ensures all LLM costs are tracked across retry attempts
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/paperqa/docs.py | Updates result handling to process lists of LLM results and filter out None contexts |
| src/paperqa/core.py | Implements retry logic with new exception class and refactored function structure |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
f7bde6f to
61ab567
Compare
61ab567 to
4758b0c
Compare
whitead
reviewed
Sep 10, 2025
Collaborator
whitead
left a comment
There was a problem hiding this comment.
Any ideas for a test? Maybe a mock llm that throws bad JSON on first call and valid JSON on second?
Co-authored-by: Andrew White <white.d.andrew@gmail.com>
Collaborator
Author
Sure, I just created |
maykcaldas
approved these changes
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where, if the LLM poses bad JSON, it would crash
gather_evidence. Now:Contextcreation is retried, with details on the prior failureContextis ditched, with a helpfullogger.exceptionIt also takes care to index all LLM costs across retries.