Filtering out null byte from table ParsedMedia.text#1088
Merged
jamesbraza merged 1 commit intomainfrom Sep 15, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a PostgreSQL database encoding error caused by null bytes in table markdown text extracted from PDFs. The solution filters out invalid control characters (specifically null bytes) from table markdown text before storing it in the database.
- Adds regex pattern to detect invalid UTF-8 characters (null bytes) in table markdown
- Modifies table parsing to set text to None when invalid characters are detected
- Adds comprehensive test coverage to verify the filtering behavior
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/paper-qa-pymupdf/src/paperqa_pymupdf/reader.py | Implements null byte filtering logic with regex pattern and conditional text assignment |
| packages/paper-qa-pymupdf/tests/test_paperqa_pymupdf.py | Adds test case with mocked table data containing null bytes to verify filtering works correctly |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Related Documentation 1 document(s) may need updating based on files changed in this PR |
47a9209 to
2d4de4d
Compare
nadolskit
approved these changes
Sep 15, 2025
|
Documentation Updates 1 document(s) were updated by changes in this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seen in logs when using multimodal
paper-qa+ PyMuPDF reader + PostgreSQL DB:This PR fixes this issue within PaperQA by filtering out invalid Markdown
text