Skip to content

Removed other from doc details for user#1092

Merged
whitead merged 2 commits intomainfrom
frame
Sep 19, 2025
Merged

Removed other from doc details for user#1092
whitead merged 2 commits intomainfrom
frame

Conversation

@whitead
Copy link
Copy Markdown
Collaborator

@whitead whitead commented Sep 19, 2025

These are huge and arbitrary with no guarantees on structure.

Copilot AI review requested due to automatic review settings September 19, 2025 00:12
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 19, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the "other" field from document details when filtering content for user display. The change prevents potentially large and arbitrary data structures from being included in user-facing responses.

  • Excludes the "other" field from document model dumps in addition to "embedding"

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@dosubot
Copy link
Copy Markdown

dosubot bot commented Sep 19, 2025

Related Documentation

Checked 1 published document(s). No updates required.

How did I do? Any feedback?  Join Discord

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 19, 2025
@whitead whitead merged commit 17b48b1 into main Sep 19, 2025
5 checks passed
@whitead whitead deleted the frame branch September 19, 2025 00:38
@dosubot
Copy link
Copy Markdown

dosubot bot commented Sep 19, 2025

Documentation Updates

Checked 1 published document(s). No updates required.

How did I do? Any feedback?  Join Discord

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants