Enforcing DocDetails.tzinfo to be UTC#1094
Merged
jamesbraza merged 1 commit intomainfrom Sep 19, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR resolves a TypeError that occurs when comparing offset-naive and offset-aware datetimes by enforcing all DocDetails.publication_date fields to be in UTC timezone.
- Added a field validator to
DocDetailsclass that ensures all publication dates are converted to UTC - Updated test data to use UTC-aware datetime objects
- Added UTC import to necessary files
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/paperqa/types.py | Added field validator to convert publication_date to UTC and imported UTC |
| tests/test_clients.py | Updated test datetime objects to use UTC timezone and imported UTC |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
mskarlin
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seen in client code:
This PR resolves this issue by ensuring all
publication_dateare in UTC