Skip to content

Exposing DOC_DETAILS_OTHERS_TO_KEEP for subclassers#1115

Merged
jamesbraza merged 1 commit intomainfrom
extensible-other-keys
Oct 2, 2025
Merged

Exposing DOC_DETAILS_OTHERS_TO_KEEP for subclassers#1115
jamesbraza merged 1 commit intomainfrom
extensible-other-keys

Conversation

@jamesbraza
Copy link
Copy Markdown
Collaborator

This let's subclasses of PQASession expand the DOC_DETAILS_OTHERS_TO_KEEP if desired

@jamesbraza jamesbraza self-assigned this Oct 2, 2025
@jamesbraza jamesbraza added the enhancement New feature or request label Oct 2, 2025
Copilot AI review requested due to automatic review settings October 2, 2025 20:39
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Oct 2, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the DOC_DETAILS_OTHERS_TO_KEEP constant to be a class variable on PQASession, enabling subclasses to customize which document detail fields are preserved during user content filtering.

  • Moved DOC_DETAILS_OTHERS_TO_KEEP from module-level constant to a ClassVar on PQASession
  • Updated the filtering logic to reference the class variable instead of the global constant

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@dosubot
Copy link
Copy Markdown

dosubot bot commented Oct 2, 2025

Related Documentation

Checked 1 published document(s). No updates required.

How did I do? Any feedback?  Join Discord

@jamesbraza jamesbraza merged commit 1d1990c into main Oct 2, 2025
5 checks passed
@jamesbraza jamesbraza deleted the extensible-other-keys branch October 2, 2025 21:53
@dosubot
Copy link
Copy Markdown

dosubot bot commented Oct 2, 2025

Documentation Updates

Checked 1 published document(s). No updates required.

How did I do? Any feedback?  Join Discord

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants