Exposing DOC_DETAILS_OTHERS_TO_KEEP for subclassers#1115
Merged
jamesbraza merged 1 commit intomainfrom Oct 2, 2025
Merged
Conversation
… clients can extend it
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the DOC_DETAILS_OTHERS_TO_KEEP constant to be a class variable on PQASession, enabling subclasses to customize which document detail fields are preserved during user content filtering.
- Moved
DOC_DETAILS_OTHERS_TO_KEEPfrom module-level constant to aClassVaronPQASession - Updated the filtering logic to reference the class variable instead of the global constant
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
sidnarayanan
approved these changes
Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This let's subclasses of
PQASessionexpand theDOC_DETAILS_OTHERS_TO_KEEPif desired