Expanding temperature autoset to 1 for GPT-5#1145
Merged
jamesbraza merged 1 commit intomainfrom Oct 20, 2025
Merged
Conversation
jamesbraza
requested review from
maykcaldas,
mskarlin,
nadolskit,
sidnarayanan and
whitead
jamesbraza
changed the title
temperature autosettemperature autoset to 1 for GPT-5
dosubot
bot
added
size:M
|
Documentation Updates Checked 1 published document(s). No updates required. How did I do? Any feedback? |
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds automatic temperature enforcement (set to 1) for additional OpenAI model prefixes and updates related tests.
- Generalizes validator to cover both o1 and gpt-5 model families.
- Refactors test to parametrize multiple model names and consolidate warning assertions.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/test_configs.py | Expands test to cover multiple model prefixes and verifies temperature coercion and absence of duplicate warnings. |
| src/paperqa/settings.py | Generalizes temperature enforcement validator and updates warning message and docstring. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
whitead
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know this code was a hack and should live in LMI, but I am just continuing it for now 😈