Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR generalizes unit tests to accommodate Claude 4.5 Sonnet in addition to existing GPT models. The changes make test assertions more flexible to handle different LLM response formats and improve test clarity through better naming and fixed typos.
Key Changes
- Updated assertions to accept multiple valid response formats (e.g., "1.0mm", "1.0-mm", "1.0 mm")
- Fixed typo "What is is" → "What is" in multiple test queries
- Improved test data naming from generic "stub"/"special" to descriptive "positive"/"negative"
Reviewed Changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/test_paperqa.py | Replaced exact string matching with regex pattern, improved test data naming from stub/special to positive/negative, clarified comments, added context assertion |
| tests/test_configs.py | Extended LLM name check to accept both "gpt-" and "claude-" prefixes |
| tests/test_agents.py | Fixed duplicate word typo in test queries, increased context substring check from 20 to 30 characters |
| tests/conftest.py | Fixed duplicate word typo in test query fixture |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
… increase reliability
283f8a6 to
8c04cb4
Compare
maykcaldas
approved these changes
Oct 21, 2025
mskarlin
approved these changes
Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adjusts unit tests to also apply for Claude 4.5 Sonnet