Skip to content

Simplifying prompt newlines to use --- hrule and removed extra hrules #1156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamesbraza merged 9 commits into from
Oct 29, 2025
Merged

Simplifying prompt newlines to use --- hrule and removed extra hrules #1156

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3189dcd
Simplified prompting around Markdown table text
jamesbraza Oct 27, 2025
7396a7f
Moved to three dashes for prompt delimiters
jamesbraza Oct 27, 2025
d426d75
Reusing summary_json_prompt in summary_prompt, cleaned up newlines
jamesbraza Oct 27, 2025
255a0c5
Added failure branch for empty text
jamesbraza Oct 27, 2025
e0acf36
Moved context_str_body to use three dashes for prompt delimiter as well
jamesbraza Oct 27, 2025
0f07b99
Added missing period to text_with_tables_prompt_template
jamesbraza Oct 27, 2025
915c3ce
Fixed missing space in summary_prompt
jamesbraza Oct 27, 2025
02b1296
Removed extra spaces from CITATION_KEY_CONSTRAINTS
jamesbraza Oct 27, 2025
9491b9b
Refreshing cassettes as needed
jamesbraza Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Moved context_str_body to use three dashes for prompt delimiter as well
  • Loading branch information
@jamesbraza
jamesbraza committed Oct 27, 2025
commit e0acf36ccc4c113be2e1d114caaabdf8038320ef
2 changes: 1 addition & 1 deletion src/paperqa/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1111,7 +1111,7 @@ async def context_serializer(
)
section = f"{section_header}\n\n" + "\n\n".join(inner_strs)
context_sections.append(section)
context_str_body = "\n\n----\n\n".join(context_sections)
context_str_body = "\n\n---\n\n".join(context_sections)
else:
inner_context_strs = [
context_inner_prompt.format(
Expand Down
2 changes: 1 addition & 1 deletion tests/test_paperqa.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,7 +743,7 @@ async def test_aquery_groups_contexts_by_question(docs_fixture) -> None:
assert "Details on how drug discovery leverages AI." in final_context_str
assert "General facts about organic chemistry." in final_context_str

assert "\n\n----\n\n" in final_context_str
assert "\n\n---\n\n" in final_context_str
q1_header_pos = final_context_str.find(
'Contexts related to the question: "Is XAI usable in chemistry?"'
)
Expand Down