Better crash on None value for fields_to_overwrite_from_metadata

[jamesbraza]

Nice-ifying this error

[Copilot]

Pull Request Overview

This PR fixes a TypeError crash that occurred when fields_to_overwrite_from_metadata was explicitly set to None. The fix ensures that a ValidationError is raised instead, providing clearer error handling.

Key changes:

• Modified data.get() calls to use the or operator instead of providing a default value directly to get(), ensuring None values are properly handled
• Added a test case to verify that ValidationError is raised when None is passed to fields_to_overwrite_from_metadata

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
src/paperqa/types.py	Replaced data.get("fields_to_overwrite_from_metadata", DEFAULT_FIELDS_TO_OVERWRITE_FROM_METADATA) with data.get("fields_to_overwrite_from_metadata") or DEFAULT_FIELDS_TO_OVERWRITE_FROM_METADATA in four locations to properly handle None values
tests/test_paperqa.py	Added test case to verify ValidationError is raised when fields_to_overwrite_from_metadata=None is passed to DocDetails

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[dosubot]

Documentation Updates

Checked 1 published document(s). No updates required.

^{How did I do? Any feedback?}