'Full page screenshot' enrichment prompt template #1162
Merged
+21
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt_prompt_template, to be clear
jamesbraza
requested review from
alexandonian,
maykcaldas,
mskarlin,
nadolskit,
sidnarayanan and
whitead
dosubot
bot
added
the
size:S
|
Related Documentation Checked 1 published document(s) in 1 knowledge base(s). No updates required. How did I do? Any feedback? |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the media enrichment prompt templates to distinguish between individual media items (images/tables) and full-page screenshots. The changes rename the existing prompt template and add a new one for future full-page screenshot support.
- Renames
media_enrichment_prompt_templatetoindividual_media_enrichment_prompt_templatefor clarity - Adds new
full_page_enrichment_prompt_templatefor full-page screenshot enrichment - Updates import and usage in settings to reflect the renamed template
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/paperqa/prompts.py | Renames media enrichment prompt to individual_media_enrichment_prompt_template and adds new full_page_enrichment_prompt_template |
| src/paperqa/settings.py | Updates import and default value to use renamed individual_media_enrichment_prompt_template |
Comments suppressed due to low confidence (1)
src/paperqa/prompts.py:1
- The newly added
full_page_enrichment_prompt_templateis not imported or used anywhere in the codebase yet. Consider adding a docstring or comment explaining that this template is for future use with full-page screenshot parsing, or complete the implementation by importing and using it in the appropriate places.
from datetime import datetime
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
maykcaldas
reviewed
Oct 31, 2025
maykcaldas
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a prompt template for full-page screenshots