Removed trailing whitespace from formatted_answer
#1167
Merged
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbraza
requested review from
MicPie,
jabra,
maykcaldas,
mskarlin,
nadolskit and
sidnarayanan
dosubot
bot
added
the
size:XS
|
Related Documentation Checked 1 published document(s) in 1 knowledge base(s). No updates required. How did I do? Any feedback? |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes trailing whitespace from formatted answers by eliminating an unnecessary newline character in the bibliography formatting. The change ensures that formatted_answer has no leading or trailing whitespace, which is now enforced by a new test assertion.
- Removed trailing newline from bibliography formatting in
populate_formatted_answers_and_bib_from_raw_answer() - Added test assertion to verify no leading/trailing whitespace in formatted answers
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/paperqa/types.py | Removed trailing \n from bibliography string formatting to eliminate trailing whitespace |
| tests/test_paperqa.py | Added assertion to verify formatted_answer has no leading/trailing whitespace |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
whitead
approved these changes
Nov 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See PR title