Make OpenAlex work #1168
Merged
Make OpenAlex work #1168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
|
Related Documentation Checked 1 published document(s) in 1 knowledge base(s). No updates required. How did I do? Any feedback? |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for removing the DOI prefix from OpenAlex API responses and includes a test to verify OpenAlex integration works correctly.
- Adds DOI prefix removal logic to normalize DOI format from OpenAlex responses
- Introduces a new test to verify OpenAlex provider functionality
- Adjusts whitespace formatting in the OpenAlex client code
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/test_clients.py | Imports OpenAlexProvider and adds test for OpenAlex DOI query functionality |
| src/paperqa/clients/openalex.py | Adds DOI prefix normalization to remove "https://doi.org/" prefix from OpenAlex responses and adjusts whitespace |
| tests/cassettes/test_does_openalex_work[10.1021-acs.jctc.5b00178].yaml | VCR cassette recording for the new OpenAlex test |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out openalex never worked if you query on DOI. OpenAlex refers to DOIs always with the URL prefix (e.g., https://doi.org/10xxx/xxxxx). So when it returned articles, they had DOIs that didn't match the requested DOIs and we rejected them as failed. This fixes and adds a low-effort unit test that just checks if openalex is working.
Note
Normalize OpenAlex DOIs by removing the https://doi.org/ prefix before comparison and add a VCR test to verify DOI queries work via OpenAlexProvider.
doiby removinghttps://doi.org/prefix in API results before matching against requested DOI.OpenAlexProviderto tests and new async testtest_does_openalex_workquerying by DOI withfields=["open_access"].OpenAlex.Written by Cursor Bugbot for commit 0da01b2. Configure here.