Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modernizes bundled configuration files to align with the new parsing settings structure introduced in PR #1054, and adds a test to ensure all bundled configs can be loaded successfully.
Key Changes:
- Adds a test that validates all bundled JSON configs can be loaded via
get_settings() - Migrates parsing configuration from old flat structure (
chunk_size,overlap) to new nested structure (reader_config.chunk_chars,reader_config.overlap) - Removes deprecated
chunking_algorithmfield from configs
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_configs.py | Adds test to validate all bundled configs load successfully using subtests for each config file |
| src/paperqa/configs/wikicrow.json | Modernizes parsing config: moves chunk_size/overlap to reader_config dict, removes chunking_algorithm |
| src/paperqa/configs/tier5_limits.json | Modernizes parsing config: moves chunk_size/overlap to reader_config dict |
| src/paperqa/configs/tier4_limits.json | Modernizes parsing config: moves chunk_size/overlap to reader_config dict |
| src/paperqa/configs/tier3_limits.json | Modernizes parsing config: moves chunk_size/overlap to reader_config dict |
| src/paperqa/configs/tier2_limits.json | Modernizes parsing config: moves chunk_size/overlap to reader_config dict |
| src/paperqa/configs/search_only_clinical_trials.json | Modernizes parsing config: moves chunk_size/overlap to reader_config dict |
| src/paperqa/configs/openreview.json | Modernizes parsing config: moves chunk_size to reader_config.chunk_chars |
| src/paperqa/configs/high_quality.json | Modernizes parsing config: moves chunk_size/overlap to reader_config dict |
| src/paperqa/configs/contracrow.json | Modernizes parsing config: moves chunk_size/overlap to reader_config dict, removes chunking_algorithm |
| src/paperqa/configs/clinical_trials.json | Modernizes parsing config: moves chunk_size/overlap to reader_config dict |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
whitead
approved these changes
Dec 22, 2025
|
Hi! Thank you for fixes, now importing filename from config name works fine. However, another issue is raised, when I am trying to set myself a custom config. For example: from paperqa.settings import (
AgentSettings,
AnswerSettings,
IndexSettings,
ParsingSettings,
PromptSettings,
Settings,
)
settings=Settings(
AnswerSettings(
evidence_k=10,
evidence_detailed_citations=True,
evidence_retrieval=True,
evidence_summary_length="about 100 words",
evidence_skip_summary=False,
answer_max_sources=5,
max_answer_attempts=None,
answer_length="must not exceed 1000 words, but sometimes can be longer",
max_concurrent_requests=10,
)
)Raises this pydantic error: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1054 missed updating the bundled configs. This PR:
Closes #1250