Unsilenced flaky test_duplicate_media_context_creation#1252
Merged
jamesbraza merged 2 commits intomainfrom Dec 22, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the debugging experience for a flaky test by expanding an assertion error message to include the actual answer content. When the test_duplicate_media_context_creation test failed in CI, the assertion message only indicated that fewer than two districts were matched, but didn't show what the actual answer was, making it difficult to debug.
- Enhanced assertion message to include the actual
session.answervalue using an f-string with repr formatting
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seen in this CI run:
This PR expands the assertion message so this can be debugged