Disabling cache reads assertion for Google Gemini#1306
Merged
jamesbraza merged 1 commit intomainfrom Feb 25, 2026
Merged
Conversation
dosubot
bot
added
the
size:S
|
Related Documentation Checked 1 published document(s) in 1 knowledge base(s). No updates required. How did I do? Any feedback? |
Contributor
There was a problem hiding this comment.
Pull request overview
Disables a flaky prompt-cache reuse assertion for the Google Gemini provider in the test_model_chain integration test, based on CI instability where Gemini does not reliably report cache read tokens.
Changes:
- Wrap the warm-cache “cache read tokens” assertion in a provider-specific exception path to avoid failing CI for Gemini.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seen in this CI run:
#1293 added prompt caching assertions, but it seems Google Gemini doesn't reliably report cache reads. It could be that the 3-sec delay isn't long enough, or it could be they have bugs. Regardless, I am just disabling this assertion for them since it's not mission critical.