Skip to content

Pulled in pyzotero typing fix#1319

Merged
jamesbraza merged 1 commit intomainfrom
zotero-import-fix
Mar 18, 2026
Merged

Pulled in pyzotero typing fix#1319
jamesbraza merged 1 commit intomainfrom
zotero-import-fix

Conversation

@jamesbraza
Copy link
Copy Markdown
Collaborator

We can now roll back the pyzotero change from #1295.

@jamesbraza jamesbraza self-assigned this Mar 18, 2026
@jamesbraza jamesbraza added the enhancement New feature or request label Mar 18, 2026
Copilot AI review requested due to automatic review settings March 18, 2026 16:54
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Mar 18, 2026
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 18, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Zotero integration to rely on the pyzotero typing fix (issue #298), allowing Zotero.dump to be called with a Path and bumping the locked pyzotero version accordingly (reverting the earlier downpin from PR #1295).

Changes:

  • Bump pyzotero resolution in uv.lock to 1.11.0 and add a dev-extra lower bound of pyzotero>=1.11.0.
  • Remove the str(...) cast when passing a Path to Zotero.dump.
  • Add pyzotero>=1.11.0 to the dev optional dependency group.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File Description
uv.lock Locks pyzotero to 1.11.0 and reflects updated dependency constraints.
src/paperqa/contrib/zotero.py Passes a Path directly to Zotero.dump (no str workaround).
pyproject.toml Adds pyzotero>=1.11.0 to the dev optional dependencies.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jamesbraza jamesbraza merged commit c726f56 into main Mar 18, 2026
10 of 11 checks passed
@jamesbraza jamesbraza deleted the zotero-import-fix branch March 18, 2026 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants