Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[CI] Do not upload dockerbuild #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
[CI] Do not upload dockerbuild #15
Changes from 1 commit
15ff271762a744edb288873b21fc8c575000fdff1b38a1958936d4f81dfb0464d7deabbe448f2c9fbcb10895d1913eeb1050afb7328a7562825682d325fb95c9733e073a3aba21fad77b1275a0f945d01e4eded8c8c8c9a87b8f2bbe8489f4128d0ba73ca4702db872a760df772bd563d642b6b45eb03cc83b88a52bc07213945c8c0fbc6b4e5ed4588399846d60613921eba82f1bce27cc72bdc202bb23ec2a9b5d71afcbeb509fefcef707347cacad0bc93295d37f211208aa722b43a222f78510edd7b0a7e2e3ab0f2d8def486babb9509d3f937eae5ca7ba7a53724f600f75d80c7418cfd124e4000738a50354288f8554d678edebb1178bbd396581e8c92f5d38187adb89efddcfcba9454367d206daf9fe353966aeaa5a0a33f16577c7024d30246a7cf4ce0ab5602fbf669264299b7d2a1472cebc7ef21ac8cdeeca9987a3d2a864f0e8cead6cdf54b6d731eea0bc044a33b9fccabbcabd4eea4c104dc2b622fa359bc8cd501c16afc577ae7adc42b4b9dbf8b1fa05b8bc5ccadece4bc05102370919e60f1e717feda672170f5c98d5308151c3af3dc8718eba5b19aa37087677bb1a63a53ce5c3d3b6dd1898a0b4467644e399818654d3c2ebb39e4b58eb0ad9ec26702366262203942cb4faf066e8b4b5a551080e14e60ce00e1890a79406beb71bbfd44ab62ba1560ed702c0cd47c3c61e23efbfe95589ee112919440a1777044c3cebd7d2b78cec216f05be9b50426defd69b2954ca56451489cea81145082b8335063f257e172d7992b1290502d8b33a830d3d3a423c77b740093c50ef8663a6a251ce616b84ec43027cf8046187b98662e16568ad2f61135b003bffc0428cb32570e50fe868fef8eaa10f32d0955193f2e65e048ff0d37236d7d929042cb557311c77b163b4b1f789951159cafe74da6f84269bcf559eab86491cf35f57904dd33a7d5d7c86f61758adb01772c4cbcdd5296d7ce6ef124a17f24511dda9128a0a28977e920634a632e681d9816b7ce7f3356df5cb7516859f5a5bf046eb96685b7abdcbdc5232d2a3f888da4904bab698883db3982c0fc7087cd48f98ba05e8c808af72d11ea80ed987e3d0c0f676cac01c1d80fc2305ed23785d3b63497808cf702276ca7f0d42e516cb9a0530540df3aa7570528fe2081ede34f3efe1a4c9c41e1f43d37116c20c7832e917292ff16f47783aeff679e32fb5e43915381a9be7b7c2793eFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
### What changes were proposed in this pull request? This PR adds support for extracting the second component from TIME (TimeType) values in Spark SQL. For example: ``` scala> spark.sql("SELECT SECOND(TIME'13:59:45.99')").show() +--------------------------+ |second(TIME '13:59:45.99')| +--------------------------+ | 45| +--------------------------+ scala> spark.sql("select second(cast('12:00:01.123' as time(4)))").show(false) +-------------------------------------+ |second(CAST(12:00:01.123 AS TIME(4)))| +-------------------------------------+ |1 | +-------------------------------------+ ``` ### Why are the changes needed? Spark previously supported second() for only TIMESTAMP type values. TIME support was missing, leading to implicit casting attempt to TIMESTAMP, which was incorrect. This PR ensures that second(TIME'HH:MM:SS.######') behaves correctly without unnecessary type coercion. ### Does this PR introduce _any_ user-facing change? Yes - Before this PR, calling second(TIME'HH:MM:SS.######') resulted in a type mismatch error or an implicit cast attempt to TIMESTAMP, which was incorrect. - With this PR, second(TIME'HH:MM:SS.######') now works correctly for TIME values without implicit casting. - Users can now extract the second component from TIME values natively. ### How was this patch tested? By running new tests: ```$ build/sbt "test:testOnly *TimeExpressionsSuite"``` ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#50525 from senthh/getSeconds. Authored-by: senthh <senthil.kumar@acceldata.io> Signed-off-by: Max Gekk <max.gekk@gmail.com>Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing