Skip to content

fix: switch to QgsBlockingNetworkRequest #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

fix: switch to QgsBlockingNetworkRequest #349

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a46ce95
fix: switch to QgsBlockingNetworkRequest for network calls
merydian Jun 30, 2025
6e38cab
fix: enhance error handling and retry logic for network requests
merydian Jun 30, 2025
6f676bc
docs: add to changelog
merydian Sep 24, 2025
b54d065
test: add retry logic for client on OverQueryLimit
merydian Oct 21, 2025
b60986a
refactor: use iteration instead of recursion for requests
merydian Oct 21, 2025
485b0e1
feat: use QTimer instead of time.sleep()
merydian Oct 21, 2025
803b28d
feat: add downloadProgress signal to Client
merydian Oct 21, 2025
548f240
feat: download progress reporting
merydian Oct 21, 2025
ae53ec0
docs: enhance Client class documentation
merydian Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: add downloadProgress signal to Client
  • Loading branch information
@merydian
merydian committed Oct 21, 2025
commit 803b28d5615c9918e2f2c3984fcf9c29bbdf58a3
6 changes: 6 additions & 0 deletions ORStools/common/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ class Client(QObject):
"""Performs requests to the ORS API services."""

overQueryLimit = pyqtSignal(int)
downloadProgress = pyqtSignal(int, int)


def __init__(self, provider: Optional[dict] = None, agent: Optional[str] = None) -> None:
"""
Expand Down Expand Up @@ -118,6 +120,10 @@ def fetch_with_retry(

blocking_request = QgsBlockingNetworkRequest()

blocking_request.downloadProgress.connect(
lambda r, t: self.downloadProgress.emit(r, t)
)

logger.log(f"url: {self.url}\nParameters: {json.dumps(post_json, indent=2)}", 0)

content = None
Expand Down