Draft
Conversation
* [LC-2396]: Deprecate and Feature-Flag WithCTE for Rails 7.2+ **Summary:** - Adds a config-driven feature flag (`ActiveRecordExtended.config.with_cte_enabled`) to enable/disable `WithCTE` support at runtime. - Emits deprecation warnings for `WithCTE` on Rails 7.2+ (native CTE support), with an option to silence warnings (`with_cte_deprecation_warnings_enabled`). - Disabling the feature raises clear errors if `WithCTE` is used. - Backward compatible: Rails < 7.2 is unaffected by default. - Updated README and robust tests for all scenarios. - Deprecator now uses the actual gem version. **Migration:** - For Rails 7.2+, add to an initializer to disable: ```ruby ActiveRecordExtended.config.with_cte_enabled = false ``` - To silence warnings: ```ruby ActiveRecordExtended.config.with_cte_deprecation_warnings_enabled = false ``` **Why:** - Rails 7.2+ has native CTE support. This change allows safe, configurable migration for all users. * Update to not raise on rails native supported methods * Temp: Adds debugging logging * WIP: Passing most basic with request delegation * WIP: recursive with * Get rid of debug logging * Update tests, README, and Changelog
GeorgeKaraszi
force-pushed
the
cte_deprecation
branch
from
988e8aa to
a2b33dd
Compare
GeorgeKaraszi
force-pushed
the
cte_deprecation
branch
from
a2b33dd to
7496b3c
Compare
GeorgeKaraszi
force-pushed
the
cte_deprecation
branch
from
f166aa6 to
f5e4ec8
Compare
|
@GeorgeKaraszi Hi, our project is on Rails 8.0, and we are upgrading soon to 8.1. We are relying on ARE to specify |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.