Retain bookmark order when syncing

[rnystrom]

Fixes #2537

[ijm8710]

Thank you Ryan! You’re the best!

[ijm8710]

@rnystrom did this hit the build you just pushed? Must we do AppStore overwrite then Tf, since the order didn’t sync when I just updated a second ago

[rnystrom]

Yup need to update from an old version again

_{Sent with GitHawk}

[ijm8710]

@rnystrom the order’s not syncing over from the App Store version (just did a double-install on top)

[ijm8710]

Hey Ryan just hoping you can give this another look when you get a chance before 1.26 public is pushed and we lose ability to revert

[rnystrom]

To test this:

• On a TF version, un-bookmark everything so the iCloud store is empty
• Install App Store version
• Bookmark a few things (take a screenshot to remember order)
• Install TF version
• Check that bookmarks exist and are in order

[ijm8710]

Thanks Ryan; looks like it does sync if you unbookmark everything first, I had just kept what was there thinking it would merge/overwrite.

The bookmark refactor does place newest bookmarked items at bottom though so my newest item pre-refactor and next item added since are added at opposite ends of list.

I also noticed search is gone as well.

Not sure if those are intentional design changes (if intentional, your entire sync list should reverse in order then to reflect new on bottom/old on top), unintentional, or temporary as you expand upon the refactor now.

Ideally I’d still love just a simple count to reflect how many bookmarks you have in the header bar, ability to reorder the bookmarks and some other items I had aggregated in #2376 but are now stray tickets.

[ijm8710]

@rnystrom did you have a chance to look at the above comment. One of the things I mentioned:

Old behavior : new bookmarks populate at top
Current behavior: new bookmarks populate at bottom

The old behavior makes more sense. But if this was an intentional change, it creates a non continuous feed of bookmarks whereby you have relatively new bookmarks at the top (the newest bookmarks pre-refactor), but the absolute newest bookmarks (post-refactor) are at the bottom (opposite ends)

[ijm8710]

@rnystrom does my comment here make sense? It’s like having a table listing Lebron James first 15 years in the league in order 1-15 and then placing the stats for lebron’s 16th year appended before the first year instead of sequentially following the most recent. I know you roadmapped the ability to reorder bookmarks which would be excellent, but for the time being, if that is a ways away, the current ordering is a little weird

Ideally I feel new should flow to top anyway but obv that’s more your call what you feel is best