Skip to content
Closed
Show file tree
Hide file tree
Changes from 19 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
6ae9c55
First modifications for changing from UtilPack.NuGet.MSBuild to NuGet…
stazz Mar 8, 2019
ac88f0d
Also updated .nuspec file with new dependency, and modified task fact…
stazz Mar 10, 2019
61a71eb
Making GitVersionTask.Tests compilable again.
stazz Mar 10, 2019
0bca914
Merge branch 'master' into stazz/NuGetUtilsUpdate
stazz Mar 10, 2019
844fbc0
Updated to newer NuGetUtils.MSBuild.Exec, which runs on .NET Desktop …
stazz Mar 13, 2019
bc69b43
Merge branch 'master' into stazz/NuGetUtilsUpdate
stazz Mar 13, 2019
725fbbb
Merge branch 'master' into stazz/NuGetUtilsUpdate
stazz Mar 14, 2019
e3fd1b7
Fixing a typo causing NullReferenceException.
stazz Mar 14, 2019
c2f3610
Merge branch 'master' into stazz/NuGetUtilsUpdate
stazz Mar 18, 2019
43121f3
Updating to newer NuGetUtils.MSBuild.Exec version, which fixes the bu…
stazz Mar 18, 2019
1da59e4
Merge branch 'stazz/NuGetUtilsUpdate' of https://github.com/stazz/Git…
stazz Mar 18, 2019
9d8eb38
Merge branch 'master' into stazz/NuGetUtilsUpdate
stazz Mar 19, 2019
b608f96
Merge branch 'master' into stazz/NuGetUtilsUpdate
stazz Mar 20, 2019
166ffe0
Updated NuGetUtils.MSBuild.Exec to 2.0.3.
stazz Mar 20, 2019
44c73b2
Partially changed UtilPack names to NuGetUtils.MSBuild.Exec. Need mor…
stazz Mar 20, 2019
6e16a8c
Forgot to update one reference to renamed property.
stazz Mar 20, 2019
855a7f0
Updating to newer version of NuGetUtils.MSBuild.Exec in order to cut …
stazz Mar 20, 2019
854f16b
Merge branch 'master' into stazz/NuGetUtilsUpdate
stazz Mar 21, 2019
c52b072
Do not reset Logger during call to Execute()
tpaxatb Mar 21, 2019
9be3c29
Clean up logging
tpaxatb Mar 21, 2019
4b650f0
Merge pull request #1644 from tpaxatb/bugfix/Logging
arturcic Mar 22, 2019
3b28212
Resolving conflicts related to #1644 .
stazz Mar 23, 2019
0eb2280
Resolving something else this time, no idea what.
stazz Mar 23, 2019
8898886
Resolving last conflicts
stazz Mar 27, 2019
6f64c34
Updated the NuGetUtils.MSBuild.Exec version to newer, with most recen…
stazz Mar 27, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions src/GitVersionTask/GetVersion.cs
Original file line number Diff line number Diff line change
Expand Up @@ -45,22 +45,21 @@ Input input
{
Logger.Reset();
}

return output;
}

private static Boolean ValidateInput(this Input input)
{
return !String.IsNullOrEmpty( input?.SolutionDirectory );
}

public sealed class Input
{
public string SolutionDirectory { get; set; }

public bool NoFetch { get; set; }
}

private static Boolean ValidateInput(this Input input)
{
return !String.IsNullOrEmpty( input?.SolutionDirectory );
}

public sealed class Output
{
public string Major { get; set; }
Expand Down Expand Up @@ -109,18 +108,18 @@ public sealed class Output

public string NuGetVersionV2 { get; set; }

public string VersionSourceSha { get; set; }

public string CommitsSinceVersionSource { get; set; }

public string NuGetVersion { get; set; }

public string VersionSourceSha { get; set; }

public string NuGetPreReleaseTagV2 { get; set; }

public string NuGetPreReleaseTag { get; set; }

public string CommitDate { get; set; }

public string CommitsSinceVersionSource { get; set; }

public string CommitsSinceVersionSourcePadded { get; set; }
}
}
Expand Down
12 changes: 6 additions & 6 deletions src/GitVersionTask/GitVersionTask.csproj
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="utf-8"?>
<?xml version="1.0" encoding="utf-8"?>
<Project Sdk="Microsoft.NET.Sdk">

<Import Project="$(MSBuildThisFileDirectory)\UtilPack.Version.props" Condition="exists('$(MSBuildThisFileDirectory)\UtilPack.Version.props')" />
<Import Project="$(MSBuildThisFileDirectory)\NuGetUtils.MSBuild.Exec.Version.props" Condition="exists('$(MSBuildThisFileDirectory)\NuGetUtils.MSBuild.Exec.Version.props')" />

<PropertyGroup>
<TargetFrameworks>net461;netstandard2.0</TargetFrameworks>
Expand All @@ -17,17 +17,17 @@

<NuspecFile>NugetAssets\GitVersionTask.nuspec</NuspecFile>
<PackageVersion Condition="$(PackageVersion) == '' Or $(PackageVersion) == '*Undefined*'">0.0.1-alpha-0001</PackageVersion>
<NuspecProperties>version=$(PackageVersion);configuration=$(Configuration);utilpackversion=$(PackageVersion_UtilPackNuGetMSBuild);libgit2sharpversion=$(PackageVersion_LibGit2Sharp);yamldotnetversion=$(PackageVersion_YamlDotNet)</NuspecProperties>
<NuspecProperties>version=$(PackageVersion);configuration=$(Configuration);utilpackversion=$(PackageVersion_NuGetUtilsMSBuildExec);libgit2sharpversion=$(PackageVersion_LibGit2Sharp);yamldotnetversion=$(PackageVersion_YamlDotNet)</NuspecProperties>

<Product>$(AssemblyName)</Product>
<LangVersion>latest</LangVersion>

</PropertyGroup>
<ItemGroup>
<None Remove="UtilPack.Version.props" />
<None Remove="NuGetUtils.MSBuild.Exec.Version.props" />
</ItemGroup>
<ItemGroup>
<Content Include="UtilPack.Version.props">
<Content Include="NuGetUtils.MSBuild.Exec.Version.props">
<PackagePath>build\</PackagePath>
</Content>
</ItemGroup>
Expand All @@ -38,7 +38,7 @@
<PackageReference Include="YamlDotNet" Version="$(PackageVersion_YamlDotNet)">
<PrivateAssets>All</PrivateAssets>
</PackageReference>
<PackageReference Include="NuGetUtils.MSBuild.Exec" Version="$(PackageVersion_UtilPackNuGetMSBuild)">
<PackageReference Include="NuGetUtils.MSBuild.Exec" Version="$(PackageVersion_NuGetUtilsMSBuildExec)">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
</PackageReference>
Expand Down
2 changes: 1 addition & 1 deletion src/GitVersionTask/GitVersionTaskBase.cs
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ public FileWriteInfo(
String fileExtension
)
{
this.WorkingDirectory = this.WorkingDirectory;
this.WorkingDirectory = workingDirectory;
this.FileName = fileName;
this.FileExtension = fileExtension;
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<PropertyGroup>
<PackageVersion_UtilPackNuGetMSBuild>2.0.0</PackageVersion_UtilPackNuGetMSBuild>
<PackageVersion_NuGetUtilsMSBuildExec>2.0.4</PackageVersion_NuGetUtilsMSBuildExec>
</PropertyGroup>
</Project>

10 changes: 5 additions & 5 deletions src/GitVersionTask/NugetAssets/GitVersionTask.nuspec
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?xml version="1.0" encoding="utf-8"?>
<?xml version="1.0" encoding="utf-8"?>
<package xmlns="http://schemas.microsoft.com/packaging/2013/05/nuspec.xsd">
<metadata>
<id>GitVersionTask</id>
Expand All @@ -17,22 +17,22 @@
<tags>Git Versioning GitVersion GitFlowVersion GitFlow GitHubFlow SemVer</tags>
<dependencies>
<group>
<dependency id="UtilPack.NuGet.MSBuild" version="$utilpackversion$" exclude="Build,Analyzers" />
<dependency id="NuGetUtils.MSBuild.Exec" version="$utilpackversion$" exclude="Build,Analyzers" />
</group>
<group targetFramework=".NETStandard2.0">
<dependency id="UtilPack.NuGet.MSBuild" version="$utilpackversion$" exclude="Build,Analyzers" />
<dependency id="NuGetUtils.MSBuild.Exec" version="$utilpackversion$" exclude="Build,Analyzers" />
<dependency id="LibGit2Sharp" version="$libgit2sharpversion$" exclude="Build,Analyzers" />
<dependency id="YamlDotNet" version="$yamldotnetversion$" exclude="Build,Analyzers" />
</group>
<group targetFramework=".NETFramework4.6.1">
<dependency id="UtilPack.NuGet.MSBuild" version="$utilpackversion$" exclude="Build,Analyzers" />
<dependency id="NuGetUtils.MSBuild.Exec" version="$utilpackversion$" exclude="Build,Analyzers" />
</group>
</dependencies>
</metadata>
<files>
<file src="..\NugetAssets\build\**" target="build" />
<file src="..\NugetAssets\build\GitVersionTask.targets" target="buildMultiTargeting" />
<file src="..\bin\$configuration$\**" target="build" />
<file src="..\UtilPack.Version.props" target="build" />
<file src="..\NuGetUtils.MSBuild.Exec.Version.props" target="build" />
</files>
</package>
11 changes: 9 additions & 2 deletions src/GitVersionTask/NugetAssets/build/Infrastructure.props
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<<<<<<< HEAD
<Import Project="$(MSBuildThisFileDirectory)\UtilPack.Version.props" Condition="exists('$(MSBuildThisFileDirectory)\UtilPack.Version.props')" />
=======
<Import Project="$(MSBuildThisFileDirectory)\NuGetUtils.MSBuild.Exec.Version.props" Condition="exists('$(MSBuildThisFileDirectory)\NuGetUtils.MSBuild.Exec.Version.props')" />
>>>>>>> 854f16b6753d84214c78af52224f90500da7ac11

<!-- Properties containing paths to functionality files and directories. -->
<PropertyGroup>
Expand All @@ -10,7 +14,11 @@
</PropertyGroup>

<PropertyGroup Condition=" '$(NuGetUtilsMSBuildExecAssemblyPath)' == ''">
<<<<<<< HEAD
<UtilPackVersion>$(PackageVersion_UtilPackNuGetMSBuild)</UtilPackVersion>
=======
<UtilPackVersion>$(PackageVersion_NuGetUtilsMSBuildExec)</UtilPackVersion>
>>>>>>> 854f16b6753d84214c78af52224f90500da7ac11
<UtilPackNuGetMSBuildPropsPath Condition=" '$(UtilPackNuGetMSBuildPropsPath)' == ''">$(MSBuildThisFileDirectory)../../../nugetutils.msbuild.exec/$(UtilPackVersion)/build/NuGetUtils.MSBuild.Exec.props</UtilPackNuGetMSBuildPropsPath>
<UtilPackNuGetMSBuildPropsAbsolutePath>$([System.IO.Path]::GetFullPath('$(UtilPackNuGetMSBuildPropsPath)'))</UtilPackNuGetMSBuildPropsAbsolutePath>
<!-- Set absolute path to empty string if automatic deduction failed. -->
Expand All @@ -23,8 +31,7 @@

<PropertyGroup>
<UtilPackTaskFactoryParametersXML Condition=" '$(MSBuildRuntimeType)' != 'Core' ">
<NuGetFramework>.NETFramework</NuGetFramework>
<NuGetFrameworkVersion>4.6.1</NuGetFrameworkVersion>
<NuGetFramework>net461</NuGetFramework>
</UtilPackTaskFactoryParametersXML>
<UtilPackTaskFactoryParametersXML>
$(UtilPackTaskFactoryParametersXML)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,11 @@
</PropertyGroup>
<UsingTask
Condition=" '$(NuGetUtilsMSBuildExecAssemblyPath)' != '' "
<<<<<<< HEAD
TaskFactory="UtilPack.NuGet.MSBuild.NuGetTaskRunnerFactory"
=======
TaskFactory="NuGetUtils.MSBuild.Exec.NuGetExecutionTaskFactory"
>>>>>>> 854f16b6753d84214c78af52224f90500da7ac11
AssemblyFile="$(NuGetUtilsMSBuildExecAssemblyPath)"
TaskName="GitVersionTask.UpdateAssemblyInfo">
<Task>
Expand All @@ -53,7 +57,11 @@
</UsingTask>
<UsingTask
Condition=" '$(NuGetUtilsMSBuildExecAssemblyPath)' != '' "
<<<<<<< HEAD
TaskFactory="UtilPack.NuGet.MSBuild.NuGetTaskRunnerFactory"
=======
TaskFactory="NuGetUtils.MSBuild.Exec.NuGetExecutionTaskFactory"
>>>>>>> 854f16b6753d84214c78af52224f90500da7ac11
AssemblyFile="$(NuGetUtilsMSBuildExecAssemblyPath)"
TaskName="GitVersionTask.GenerateGitVersionInformation">
<Task>
Expand All @@ -65,7 +73,11 @@
</UsingTask>
<UsingTask
Condition=" '$(NuGetUtilsMSBuildExecAssemblyPath)' != '' "
<<<<<<< HEAD
TaskFactory="UtilPack.NuGet.MSBuild.NuGetTaskRunnerFactory"
=======
TaskFactory="NuGetUtils.MSBuild.Exec.NuGetExecutionTaskFactory"
>>>>>>> 854f16b6753d84214c78af52224f90500da7ac11
AssemblyFile="$(NuGetUtilsMSBuildExecAssemblyPath)"
TaskName="GitVersionTask.GetVersion">
<Task>
Expand All @@ -77,7 +89,11 @@
</UsingTask>
<UsingTask
Condition=" '$(NuGetUtilsMSBuildExecAssemblyPath)' != '' "
<<<<<<< HEAD
TaskFactory="UtilPack.NuGet.MSBuild.NuGetTaskRunnerFactory"
=======
TaskFactory="NuGetUtils.MSBuild.Exec.NuGetExecutionTaskFactory"
>>>>>>> 854f16b6753d84214c78af52224f90500da7ac11
AssemblyFile="$(NuGetUtilsMSBuildExecAssemblyPath)"
TaskName="GitVersionTask.WriteVersionInfoToBuildLog">
<Task>
Expand Down
1 change: 0 additions & 1 deletion src/GitVersionTask/UpdateAssemblyInfo.cs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ namespace GitVersionTask

public static class UpdateAssemblyInfo
{

public static Output Execute(
Input input
)
Expand Down