Skip to content

Conversation

@jbaehr
Copy link
Contributor

@jbaehr jbaehr commented Oct 9, 2019

This fixes #1823.

Tests have been done with with MSBuild-14, MSBuild-15.8 and NetSdk-2.2 (aka MSBuild-15.9).
MSBuild-15 works without this patch, but MSBuild-14 seems to require the namespace, otherwise you'll encounter the following error:

C:\...\GitVersionTask.props(2,1): error MSB4041: The default XML namespace of the project must be the MSBuild XML namespace. If the project is authored in the MSBuild 2003 format, please add xmlns="http://schemas.microsoft.com/developer/msbuild/2003" to the <Project> element. If the project has been authored in the old 1.0 or 1.2 format, please convert it to MSBuild 2003 format. [C:\...\MyProject.csproj]

@arturcic
Copy link
Member

arturcic commented Oct 9, 2019

@jbaehr, thanks for taking the time to implement it again. I'll merge it when the build passes

@arturcic arturcic added this to the 5.1.0 milestone Oct 9, 2019
@arturcic arturcic added the bug label Oct 9, 2019
@arturcic arturcic merged commit a4325e0 into GitTools:master Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitVersionTask 5.0.1 does not work with MSBuild-14.0

2 participants