fix sonarcloud

src/GitVersion.Core.Tests/Formatting/ValueFormatterTests.cs

@@ -122,7 +122,7 @@ public bool TryFormat(object? value, string format, out string result)
             return false;
         }
 
-        public bool TryFormat(object? value, string format, CultureInfo cultureInfo, out string result)
+        public bool TryFormat(object? value, string format, CultureInfo _, out string result)
             => TryFormat(value, format, out result);
     }
 }

src/GitVersion.Core/Formatting/DateFormatter.cs

@@ -16,7 +16,7 @@ public override bool TryFormat(object? value, string format, CultureInfo culture
             return true;
         }
 
-        if (value is string dateStr && DateTime.TryParse(dateStr, out var parsedDate))
+        if (value is string dateStr && DateTime.TryParse(dateStr, cultureInfo, out var parsedDate))
         {
             result = parsedDate.ToString(format, cultureInfo);
             return true;

src/GitVersion.Core/PublicAPI.Unshipped.txt

@@ -31,6 +31,7 @@ GitVersion.VersionCalculation.BaseVersionOperator.BaseVersionOperator() -> void
 GitVersion.VersionCalculation.BaseVersionOperator.Equals(GitVersion.VersionCalculation.BaseVersionOperator? other) -> bool
 GitVersion.VersionCalculation.Caching.GitVersionCacheKey.Deconstruct(out string! Value) -> void
 GitVersion.VersionCalculation.Caching.GitVersionCacheKey.GitVersionCacheKey(GitVersion.VersionCalculation.Caching.GitVersionCacheKey! original) -> void
+GitVersion.VersionCalculation.IVersionFilter.Exclude(GitVersion.Git.ICommit? commit, out string? reason) -> bool
 GitVersion.WixInfo.WixInfo() -> void
 GitVersion.WixInfo.WixInfo(GitVersion.WixInfo! original) -> void
 override GitVersion.Configuration.EffectiveBranchConfiguration.Equals(object? obj) -> bool
@@ -150,4 +151,3 @@ GitVersion.Configuration.IIgnoreConfiguration.Paths.get -> System.Collections.Ge
 GitVersion.Git.ICommit.DiffPaths.get -> System.Collections.Generic.IReadOnlyList<string!>!
 GitVersion.Git.ITreeChanges
 GitVersion.Git.ITreeChanges.Paths.get -> System.Collections.Generic.IReadOnlyList<string!>!
-GitVersion.VersionCalculation.IVersionFilter.Exclude(GitVersion.Git.ICommit! commit, out string? reason) -> bool

src/GitVersion.Core/VersionCalculation/Abstractions/IVersionFilter.cs

@@ -5,5 +5,5 @@ namespace GitVersion.VersionCalculation;
 public interface IVersionFilter
 {
     bool Exclude(IBaseVersion baseVersion, out string? reason);
-    bool Exclude(ICommit commit, out string? reason);
+    bool Exclude(ICommit? commit, out string? reason);
 }

src/GitVersion.Core/VersionCalculation/MinDateVersionFilter.cs

@@ -19,7 +19,7 @@ public bool Exclude(IBaseVersion baseVersion, [NotNullWhen(true)] out string? re
         return true;
     }
 
-    public bool Exclude(ICommit commit, [NotNullWhen(true)] out string? reason)
+    public bool Exclude(ICommit? commit, [NotNullWhen(true)] out string? reason)
     {
         reason = null;