Skip to content

tests(report-ui-features): add empty list and single item test cases #10201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patrickhulce merged 2 commits into from
Jan 10, 2020
Merged

tests(report-ui-features): add empty list and single item test cases #10201

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e06d455
tests(reportuifeatures): adding empty list and single item test cases
Jan 8, 2020
f06cd3c
made test case more interesting per review feedback
Jan 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions lighthouse-core/test/report/html/renderer/report-ui-features-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,22 @@ describe('ReportUIFeatures', () => {
createDiv = () => dom.document().createElement('div');
});

it('should return undefined when nodes is empty', () => {
const nodes = [];

const nextNode = dropDown._getNextSelectableNode(nodes);

assert.strictEqual(nextNode, undefined);
});

it('should return the only node when start is defined', () => {
const node = createDiv();

const nextNode = dropDown._getNextSelectableNode([node], node);

assert.strictEqual(nextNode, node);
});

it('should return first node when start is undefined', () => {
const nodes = [createDiv(), createDiv()];

Expand Down