Skip to content

fix: evaluateAsync behavior #1037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brendankenny merged 7 commits into from
Dec 3, 2016
Merged

fix: evaluateAsync behavior #1037

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
46b8301
fix: evaluateAsync behavior
patrickhulce Nov 23, 2016
11ddfa7
fix: consistency with feedback on other PRs
patrickhulce Nov 29, 2016
ca5091d
more feedback
patrickhulce Nov 30, 2016
c8e14c7
more more feedback
patrickhulce Dec 2, 2016
1343e61
Merge remote-tracking branch 'upstream/master' into fix_evaluate_async
patrickhulce Dec 2, 2016
a97a2ea
Merge remote-tracking branch 'upstream/master' into fix_evaluate_async
patrickhulce Dec 2, 2016
7c5995f
doh
patrickhulce Dec 2, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge remote-tracking branch 'upstream/master' into fix_evaluate_async
  • Loading branch information
@patrickhulce
patrickhulce committed Dec 2, 2016
commit a97a2ea692bb90598b33eb864f001792cdcff2a5
3 changes: 1 addition & 2 deletions lighthouse-core/audits/dobetterweb/link-blocking-first-paint.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,7 @@ class LinkBlockingFirstPaintAudit extends Audit {
if (artifact.value === -1) {
return {
rawValue: -1,
debugString: (artifact && artifact.debugString) ||
'TagsBlockingFirstPaint gatherer did not run'
debugString: artifact.debugString
};
}

Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.