Skip to content

core: add type checking to page functions #11958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devtools-bot merged 3 commits into from
Jan 15, 2021
Merged

core: add type checking to page functions #11958

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0075e53
core: add type checking to page functions
brendankenny Jan 14, 2021
886eafe
Update lighthouse-core/lib/page-functions.js
brendankenny Jan 14, 2021
1273356
no need to stare into the void
brendankenny Jan 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lighthouse-core/gather/driver.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1112,7 +1112,6 @@ class Driver {
async cacheNatives() {
await this.evaluateScriptOnNewDocument(`
window.__nativePromise = Promise;
window.__nativeError = Error;
Copy link
Contributor Author

@brendankenny brendankenny Jan 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT this hasn't been used since #5509

window.__nativeURL = URL;
window.__ElementMatches = Element.prototype.matches;
window.__perfNow = performance.now.bind(performance);
Expand Down
Loading