Skip to content

core(errors-in-console): properly define default options #12200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devtools-bot merged 1 commit into from
Mar 5, 2021
Merged

core(errors-in-console): properly define default options #12200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lighthouse-core/audits/errors-in-console.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ class ErrorLogs extends Audit {
}

/** @return {AuditOptions} */
static defaultOptions() {
static get defaultOptions() {
// Any failed network requests with error messsage aren't actionable
return {ignoredPatterns: ['ERR_BLOCKED_BY_CLIENT.Inspector']};
}
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-core/test/audits/errors-in-console-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ describe('ConsoleMessages error logs audit', () => {
'url': 'https://www.facebook.com/tr/',
'text': 'Failed to load resource: net::ERR_BLOCKED_BY_CLIENT.Inspector',
}],
}, {options: ErrorLogsAudit.defaultOptions()});
}, {options: ErrorLogsAudit.defaultOptions});
assert.equal(auditResult.score, 1);
assert.equal(auditResult.details.items.length, 0);
});
Expand Down