report: fix focus in devtools, and in 3-dot menu #16802
Open
+6
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Paul: PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I once fixed this 3-dot menu in 2019 ... #9169
But it broke at some point. Maybe when we removed our custom focus-visible styling to defer to the user agent's? Since we were using
outline: inheritin the lh-button, that lost the focus styling. I'm not sure why inherit didn't fall-back to the user-agent stylesheets.Additionally, explicitly set :focus-visible outline for DevTools, which doesn't have it from any default user-agent stylesheet.