Skip to content

Report: header, footer, leftnav, share, oh my #2000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paulirish merged 34 commits into from
Apr 28, 2017
Merged

Report: header, footer, leftnav, share, oh my #2000

Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
45b289e
Report header
ebidel Apr 12, 2017
9f8014d
Reponsive styling. Use share icon instead of "Export..."
ebidel Apr 12, 2017
fef3a99
Runtime settings
ebidel Apr 12, 2017
8b4d2e7
Support report re-ender into page
ebidel Apr 12, 2017
7d9e20c
Add report functionality
ebidel Apr 12, 2017
6887af7
Split files
ebidel Apr 12, 2017
2b84229
Remove css focus stuff
ebidel Apr 12, 2017
b138885
Remove placeholders
ebidel Apr 12, 2017
c9633af
Fix tests
ebidel Apr 12, 2017
ee7fcb1
Feedback
ebidel Apr 13, 2017
3b7e90f
lighthouse -> lh
ebidel Apr 13, 2017
c717870
Tests for header/footer
ebidel Apr 13, 2017
85d6b8e
Tests for header/footer/formatter helps
ebidel Apr 13, 2017
2ff34f7
Add more tests
ebidel Apr 13, 2017
e9751c7
Fix rebase
ebidel Apr 13, 2017
2918469
Fix travis tests
ebidel Apr 14, 2017
2a60c3a
Feedback and leftnav
ebidel Apr 15, 2017
121fda3
Add 2nd arg
ebidel Apr 15, 2017
a445a6e
Styling tweaks
ebidel Apr 15, 2017
703043a
Leftnav tests
ebidel Apr 15, 2017
c237657
Disable open in viewer in ui
ebidel Apr 15, 2017
d7f3c29
Adjust passing audits summary
ebidel Apr 15, 2017
aa93acc
Merge branch 'master' into GoogleChrome-tablesclear
patrickhulce Apr 21, 2017
3899e47
Merge after rebase
ebidel Apr 25, 2017
33021e5
Fix up styling after merge
ebidel Apr 25, 2017
31a7385
Update dom usage and reset state of template stamping when exporting …
ebidel Apr 25, 2017
d33cc21
Closure cleanup
ebidel Apr 25, 2017
4bbba21
cleanup
ebidel Apr 26, 2017
a30c86e
Tests
ebidel Apr 26, 2017
d8ce09f
lh-analytics custom event
ebidel Apr 26, 2017
777adfe
fix travis
ebidel Apr 26, 2017
a1ffbf5
Travis fix?
ebidel Apr 26, 2017
e542539
bckenny feedback
ebidel Apr 28, 2017
8bf076f
3 big changes
ebidel Apr 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Travis fix?
  • Loading branch information
@ebidel
ebidel committed Apr 26, 2017
commit a1ffbf5f44bd61f3359357ea9fa4121faa80f051
2 changes: 1 addition & 1 deletion lighthouse-core/report/v2/renderer/report-features.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,4 +323,4 @@ if (typeof module !== 'undefined' && module.exports) {

/** @type {function({url: string, generatedTime: string}): string} */
self.getFilenamePrefix; // eslint-disable-line no-unused-expressions
Copy link
Contributor

@brendankenny brendankenny Apr 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this already declared in the global scope?

Copy link
Contributor

@brendankenny brendankenny Apr 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, I see the issue, file-namer.js needs to be added to the closure compiled files list (and should use this one's {url: string, generatedTime: string} instead of Object like in that file)

}
}