😈 Fix disconnect promise race. #2359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible that we were resolving the gather chain before we had disconnected. When manually launching and killing chrome this can race and result in an error to the user. This fixes that problem. \o/. Fixes #2337 --- Test plan: Run launcher with: ```ts const lighthouse = require('lighthouse'); import {launch} from './chrome-launcher'; async function runLighthouse(url: string) { const opts = { chromeFlags: ['--headless'], }; const chrome = await launch(opts); const flags = { output: 'json', port: chrome.port, }; const results = await lighthouse(url, flags); process.on('uncaughtException', (e: any) => { console.log(e); }); await chrome.kill(); return results; } runLighthouse('https://example.com'); ``` Without this patch, and then run it with the patch. Observe it now working.
Contributor
brendankenny
left a comment
brendankenny
left a comment
There was a problem hiding this comment.
This change was inevitable :) I was occasionally seeing the same error while running plots (no headless) on Linux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible that we were resolving the gather chain before we had
disconnected. When manually launching and killing chrome this can race
and result in an error to the user.
This fixes that problem. \o/.
Fixes #2337
Test plan:
Run launcher with:
Without this patch, and then run it with the patch. Observe it now working.