core(load-fast-4-pwa): use computed artifacts #4981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
approved these changes
Apr 18, 2018
| const MAXIMUM_TTFI = 10 * 1000; | ||
|
|
||
| const WHITELISTED_STATUS_CODES = [307]; | ||
| const MAXIMUM_TTI = 10 * 1000; |
Member
There was a problem hiding this comment.
Just to call out explicitly:
We're changing the PWA speed threshold from TTFI <= 10s to be a slightly more aggressive TTI < 10s.
| const metricComputationData = {trace, devtoolsLog, settings}; | ||
| const tti = await artifacts.requestConsistentlyInteractive(metricComputationData); | ||
|
|
||
| const score = Number(tti.timing <= MAXIMUM_TTI); |
Member
There was a problem hiding this comment.
https://developers.google.com/web/progressive-web-apps/checklist does say
interactive <10s for first visit on a simulated 3G network.
let's change this to < just to simplify. nice to stay single digits. :)
| const trace = artifacts.traces[Audit.DEFAULT_PASS]; | ||
| const devtoolsLog = artifacts.devtoolsLogs[Audit.DEFAULT_PASS]; | ||
| const settingOverrides = {throttlingMethod: 'simulate', throttling: mobile3GThrottling}; | ||
| const settings = |
Member
There was a problem hiding this comment.
can you drop a comment for this line?
Collaborator
Author
There was a problem hiding this comment.
yeah good call done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
means we'll never pass with the caveat :D we can always answer the question!