Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
core(tracing): support missing TracingStartedInBrowser
  • Loading branch information
patrickhulce committed Jan 31, 2019
commit 960f3323fe8a9a47213945f67e09d5d416e48441
14 changes: 14 additions & 0 deletions lighthouse-core/lib/traces/tracing-processor.js
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,20 @@ class TraceProcessor {
}
}

// Support the case where everything else fails.
const navStartEvt = events.find(e => Boolean(e.name === 'navigationStart' && e.args &&
e.args.data && e.args.data.isLoadingMainFrame && e.args.data.documentLoaderURL));
if (navStartEvt && navStartEvt.args && navStartEvt.args.data) {
const frameId = navStartEvt.args.frame;
if (frameId) {
return {
pid: navStartEvt.pid,
tid: navStartEvt.tid,
frameId,
}
}
}

throw new LHError(LHError.errors.NO_TRACING_STARTED);
}

Expand Down
1 change: 1 addition & 0 deletions types/externs.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,7 @@ declare global {
fileName?: string;
snapshot?: string;
data?: {
isLoadingMainFrame?: boolean;
documentLoaderURL?: string;
frames?: {
frame: string;
Expand Down