Skip to content

core(navigation): Add an option to ignore https errors during navigation #7574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Janpot wants to merge 13 commits into from
Closed

core(navigation): Add an option to ignore https errors during navigation #7574

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
261213b
core(navigation) Add an option to ignore https errors during navigation
Janpot Mar 19, 2019
faaf854
lint
Janpot Mar 19, 2019
d1e464f
update snapshots
Janpot Mar 19, 2019
cf45873
fix tsc
Janpot Mar 19, 2019
aefa83c
Use stable (but deprecated) Security.setOverrideCertificateErrors
Janpot Mar 19, 2019
a64b28e
only call setIgnoreHttpsErrors once in the driver lifetime
Janpot Mar 19, 2019
b70efce
refactor to use a never reslving promise
Janpot Mar 19, 2019
e1e3ea2
make _waitForever actually cancelable
Janpot Mar 19, 2019
487242a
add typing
Janpot Mar 19, 2019
d935f31
add typing
Janpot Mar 19, 2019
e90745a
lint
Janpot Mar 20, 2019
34193c7
update the golden lhr
Janpot Mar 20, 2019
5ec111e
Merge remote-tracking branch 'upstream/master' into ignore-https-errors
connorjclark Apr 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use stable (but deprecated) Security.setOverrideCertificateErrors 
Somehow this conflicts with redirectPass
  • Loading branch information
@Janpot
Janpot committed Mar 19, 2019
commit aefa83c84c543f5ee56d9eda1e42f62038b79a9f
12 changes: 11 additions & 1 deletion lighthouse-core/gather/driver.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1464,7 +1464,17 @@ class Driver {
* @return {Promise<void>}
*/
async setIgnoreHttpsErrors() {
await this.sendCommand('Security.setIgnoreCertificateErrors', {ignore: true});
// the devtools protocol also has an experimental Security.setIgnoreCertificateErrors
// https://chromedevtools.github.io/devtools-protocol/tot/Security#method-setIgnoreCertificateErrors
// It can be used instead of the following when it becomes stable.
this.on('Security.certificateError', event => {
this.sendCommand('Security.handleCertificateError', {
eventId: event.eventId,
action: 'continue',
}).catch(err => log.warn('Driver', err));
});
await this.sendCommand('Security.enable');
await this.sendCommand('Security.setOverrideCertificateErrors', {override: true});
}
}

Expand Down